Skip to content

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Jul 24, 2025

The content of the modules index.php has been updated, to reuse the information displayed in the Activities overview :-)

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 14:40
Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 43d00a6
🔍 Latest deploy log https://app.netlify.com/projects/moodledevdocs/deploys/688245f976fc18000867ce26
😎 Deploy Preview https://deploy-preview-1408--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for module index.php files to use a new centralized approach for displaying activity overviews. Instead of implementing custom logic to fetch and display activity instances, modules now redirect to a unified Activities page using the activityoverviewbase class.

Key Changes:

  • Replaced manual activity listing logic with a single redirect call
  • Updated documentation to reference the new activityoverviewbase class
  • Simplified the implementation from ~15 lines to 2 lines of functional code

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/apis/plugintypes/mod/_files/index-php.tsx Updated example code to use activityoverviewbase::redirect_to_overview_page() instead of manual activity fetching
docs/apis/plugintypes/mod/_files/index-php.mdx Added documentation explaining the new activityoverviewbase class usage

Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems OK to me. I will let the approval to the integrator.

@andrewnicols andrewnicols added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Aug 19, 2025
Copy link
Collaborator

@ferranrecio ferranrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This devdoc is not really blocked by MDL-83887. I approve it now.

@ferranrecio ferranrecio added this pull request to the merge queue Aug 20, 2025
Merged via the queue into moodle:main with commit 839cb63 Aug 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants